Skip to content

Update Linked List classes#33

Open
phrdang wants to merge 4 commits intomasterfrom
linked-list
Open

Update Linked List classes#33
phrdang wants to merge 4 commits intomasterfrom
linked-list

Conversation

@phrdang
Copy link
Member

@phrdang phrdang commented Jul 1, 2021 •
edited
Loading

Location

  • Ch. 16.6 Practice

Changes

  • Update and rename LinkedList.java
    • Rename to TestLinkedList.java
    • Add driver class to test methods
    • Update practice problem instructions to be more specific and include driver class
    • Add insert, clear methods
    • Update misc docstrings for clarity
    • Update toString() method to handle empty lists properly
  • Delete SinglyLinkedList.java (both practice and solution files)
    • This is a duplicate version of LinkedList.java, but it's implemented and documented more poorly
  • Rename the new LinkedList class into SinglyLinkedList to keep consistency with terminology in the curriculum

Notes

  • Please don't forget to update the instructions for both LinkedList and SinglyLinkedList on Notion!

TODO

  • More methods for the SinglyLinkedList class (e.g. get, set, indexOf)
    • Should we change the method names so that they're closer to the naming of the built-in LinkedList?
  • Should we simplify the Node class so that next and value are public? That way you don't have to do the awkward next() and value().
  • Add doubly linked list practice problem template and solution
  • Add circular linked list practice problem template and solution

phrdang added 2 commits July 1, 2021 15:39
@phrdang
Update and rename LinkedList.java
f64850e 
- Rename to TestLinkedList.java
- Add driver class to test methods
- Update practice problem instructions to be more specific and include driver class
- Add insert, clear methods
- Update misc docstrings for clarity
- Update toString() method to handle empty lists properly
@phrdang
Delete SinglyLinkedList
877ee90 
This is a duplicate  version of LinkedList.java and is implemented and
documented more poorly
@phrdang phrdang requested a review from atijmahesh July 1, 2021 22:58
@phrdang
Copy link
Member Author

phrdang commented Jul 2, 2021

You may want to hold off on merging this PR until Ch. 16 is done being updated. It's a bit all over the place right now in terms of the linked list methods and explanations.

This was referenced Jul 2, 2021
Open
Open
@phrdang
Rename LinkedList to SinglyLinkedList
1c46f7a 
This is to stay consistent with the curriculum,
since the built-in LinkedList is a doubly linked list.
@phrdang phrdang mentioned this pull request Jul 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atijmahesh atijmahesh Awaiting requested review from atijmahesh

At least 1 approving review is required to merge this pull request.

Assignees

@phrdang phrdang

@AlveeraMunshi AlveeraMunshi

@JJ27 JJ27

Labels

practice problem

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phrdang @AlveeraMunshi @JJ27